Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix bad null error handling for insert statement when disabling the strict SQL mode (#10161) #10254

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 24, 2019

What problem does this PR solve?

Cherry-pick #10161 to release 2.1.

@jackysp jackysp added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Apr 24, 2019
@jackysp
Copy link
Member Author

jackysp commented Apr 24, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp jackysp requested review from lysu and bb7133 April 24, 2019 09:05
@zz-jason
Copy link
Member

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss table/table.go file?- -

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 24, 2019
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Apr 24, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 4a13c71 into pingcap:release-2.1 Apr 24, 2019
@jackysp jackysp deleted the strict_mode_insert_2.1 branch May 29, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants